mtongnz / ESP8266_ArtNetNode_v2

ESP8266 based WiFi ArtNet to DMX, RDM and LED Pixels
GNU General Public License v3.0
612 stars 157 forks source link

Fixed two compilation error with ESP8266 2.6.3 core #125

Closed mrv96 closed 3 years ago

LoneWalkerWolf commented 3 years ago

Mind providing a quick description of what you have done? Just looking over your commits, you just seemed to have deleted some files. After the description, I am very happy to approve this PR, and then we just have to wait for @mtongnz to return!

mrv96 commented 3 years ago

Hi. Thank you for your comment.

Before of the next week I'll revise my branch and I will open a new PR with a cleaned commit history.


From: Alexander Hoppe @.> Sent: Friday, March 12, 2021 4:45:20 PM To: mtongnz/ESP8266_ArtNetNode_v2 @.> Cc: mrv96 @.>; Author @.> Subject: Re: [mtongnz/ESP8266_ArtNetNode_v2] Fixed two compilation error with ESP8266 2.6.3 core (#125)

Mind providing a quick description of what you have done? Just looking over your commits, you just seemed to have deleted some files. After the description, I am very happy to approve this PR, and then we just have to wait for @mtongnzhttps://github.com/mtongnz to return!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/mtongnz/ESP8266_ArtNetNode_v2/pull/125#issuecomment-797572949, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADD27VSPZAF56VZ6WN62JFDTDIZJBANCNFSM4KOVGRMQ.

mrv96 commented 3 years ago

New cleaned PR opened: https://github.com/mtongnz/ESP8266_ArtNetNode_v2/pull/133