search

mtorromeo / r8168

Linux device driver for Realtek Ethernet controllers (unofficial mirror)
https://www.realtek.com/Download/List?cate_id=584
246 stars 82 forks source link

Potential data loss and security breach when used with nfs server #4

Open petterreinholdtsen opened 8 years ago

petterreinholdtsen commented 8 years ago

In https://bugs.debian.org/807473 there is a report about this driver causing NFS mounts to hand out random or zeroed out file content. Passing the information on here to make more people aware of the problem.

mtorromeo commented 8 years ago

Version 8.042 is out. I would be interested to know if this is still present.

Thanks!

Hark0nnen commented 8 years ago

I dont have the original hardware anymore, but i just tried it on another machine and got the same result.

vesnn commented 7 years ago

Still present with 8.042 and kernel 4.9.13 on Fedora

sergey-dryabzhinsky commented 7 years ago

@vesnn No luck with 8.044?

sergey-dryabzhinsky commented 7 years ago

May be problem not in driver but NFS? http://openwall.com/lists/oss-security/2017/05/02/6

Hark0nnen commented 7 years ago

This post is about NFSv3, in my case NFSv4 was used.
Although it is obvious that NFS plays a lead role in this problem. In a situation where filesystem is accessible normally but files content is not the only possible explanation is that NFS tries to shortcut some parts on network subsystem for speed and this driver doesnt like it.

vesnn commented 7 years ago

With 8.044.2 the problem has mostly gone. The problem still remains with two ASUS MoBo's: M3A78 PRO and another one (I does not have acces to ther second now) with RTL8168/RTL8111 integrated (need to look at the character index at the end of their model number). Attached the lspci log. r8168.txt By the way, the speed is unnormal on that network adapter with r8168 module, as if it negotiates 10 Mb/s speed. I attached also iperf logs with r8169, r8168 (via r8169 and r8168 drivers) and forcedeth networ adaptors at the opposite side. Look at the nonsymmetrical speed at dirrerent traffic directions. iperf-forcedeth.txt iperf-r8168.txt iperf-r8168-r8169.txt iperf-r8169.txt Every iperf log contains logs: first from direct (iperf3 -c) and second from reverse (iperf3 -R -c) tests, wich where run on remote hosts, connected to ASUS MoBo network adaptor through the TP-Link GBE 8 port switch via CAT5E cables.

sergey-dryabzhinsky commented 3 years ago

Any updates with new drivers? Is it still hurts NFS?

ghost commented 2 years ago

Try to use nolapic in grub cmd line. With this option I got working stock r8169 driver on RTL8168/RTL8111 Ethernet rev 03.

petterreinholdtsen commented 2 years ago

[ns015]

Try to use nolapic in grub cmd line. With tis option I got working stock r6869 driver on RTL8168/RTL8111 Ethernet rev 03.

Any chance you can tell us how you got the idea to test nolapic and why it should help with this issue?

-- Happy hacking Petter Reinholdtsen