search

mtr / angular-iscroll

AngularJS module that enables iScroll 5 functionality, wrapping it in an easy-to-use directive.
MIT License
74 stars 27 forks source link

Default options override directive options #32

Closed DarthBender closed 6 years ago

DarthBender commented 8 years ago

Hi, i'm trying to set scrollbars: true as default option in iScrollService and override it in a special case but i can't do it now. Is it normal behavior or options initialization in link function should be changed from

iScroll: angular.extend({}, scope.iscroll || {}, iScrollService.defaults.iScroll)

to

iScroll: angular.extend({},iScrollService.defaults.iScroll,  scope.iscroll || {})
DarthBender commented 8 years ago

I'm sorry, any updates on this? Thank you.

mtr commented 8 years ago

I'm sorry, I just haven't had the time yet because of other work. I will look into this as soon as I get the chance.

yehor-manzhula commented 8 years ago

Hi! I've just made fix #34, please merge.

mtr commented 6 years ago

Thank you for your contribution.