search

mtransitapps / mtransit-for-android

MonTransit for Android
https://play.google.com/store/apps/details?id=org.mtransit.android
Apache License 2.0
36 stars 5 forks source link

Remove dependency on Google Play Services #2

Open png5lyfe opened 7 years ago

png5lyfe commented 7 years ago

MonTransit cannot load the map view without google play services installed. This means a large portion of the app's functionality is inaccessible. Can the app be built with a different map view, like OSM?

joelmaxuel commented 5 years ago

Came here to post the same issue; I will +1 this one instead. FWIW, it can even be a scaled back (e.g. map-free) edition for F-Droid. This app would stand out for being the only GMS-independent app using real-time GTFS data if this can be achieved.

mmathieum commented 5 years ago

The MonTransit app mtransit-for-android-gradle currently depends on Google Play Services for:

joelmaxuel commented 5 years ago

Quite a lot of tie-ins.
My understanding, then, is that you have no interest in a GSF-independent version/edition?

mmathieum commented 5 years ago

It's not that have no interest in a GoogleServiceFramework-independent flavor, it's more about prioritizing this over other features that I think more users want. But this project being open-source, I would take the time to review any Pull Request containing such feature and merge it once it's ready.

joelmaxuel commented 5 years ago

That is reasonable. I'll do a fork shortly (the android app, commons, and gradle repos) and take a look, play, what-have-you. Given the circumstance of work to be done, it would more likely be better served as it's own branch so I will start one of those.

It will very likely be a slow trudge for me to go through it, however I am that interested in the outcome. When (or even if) I manage something to send back as a PR, we can discuss future logistics of that branch (I am open to continue its maintenance but I don't want to be intrusive enough for me to submit to F-Droid - though I would like to see it there when it comes time). Feel free to close this issue for now, and thank you for the above guide. Cheers.

joelmaxuel commented 5 years ago

Hi @mmathieum , Due to RL, I have changed the scope of what is important, to have core functionality without bothersome views that have no impact/response/effect when GMS/Nlp is not present. What may end up bizarre is that even tough I have maintained half a dozen or so devices for custom firmware, compiling an APK is still a mystery for me.

Based on the Android documentation, the commit in the following link should do what the revised scope became. Please let me know if this is helpful. https://github.com/joelmaxuel/mtransit-for-android/commit/122fb9878276194653fbd14f0a2b688dc5a46b1a

As part of the revised scope, I do not believe F-Droid would be necessary (probably a lot of extra work as well if to consider the related GTFS APKs). Hope this helps.

TPS commented 5 years ago

@mmathieum Due to the GPlay shenanigans you wrote about, are you revisiting this? F-Droid would probably welcome you, if this were accomplished.

joelmaxuel commented 5 years ago

Based on what was written before, there's probably a greater amount of work to rework as FOSS and be reasonable for F-Droid than reinstate on GPlay. This is unfortunate news because even with using it without GSF as-is, it remains more complete and easier to use than GTFSOffline.

TPS commented 5 years ago

From what I've read in similar situations, even if reinstated, it may be temporary. Why not work both tracks simultaneously? #9 & https://gitlab.com/fdroid/rfp/issues/1081 could serve as meta-issues to track work toward inclusion.

joelmaxuel commented 5 years ago

Considering the F-Droid option is being started without having to make a case, working in parallel makes that easier. Given I don't have much spare time, I try not to expect the time of others. If people are offering help to achieve what they want to see, I don't have a reason to knock that.