mtreinish / stestr

A parallel Python test runner built around subunit
Apache License 2.0
27 stars 33 forks source link

Revert "Fix #330 - Preserve load-list order" #335

Closed mtreinish closed 2 years ago

mtreinish commented 2 years ago

Several issues have been reported about the run order and other odd behavior in running of tests since the 4.0.0 release including a high degree of random failures in stestr CI. #331 is the only likely candidate as to the root cause. In the interest of fixing these issues for people this commit reverts #331.

This revert was already released as part of 4.0.1. Since the main branch adopted black code formatting recently it was easier to do the straight revert on the stable branch first as there was conflicts.

This reverts commit ff25c999a59a5d8fa82ed118c53b11ed479de9bd.

codecov-commenter commented 2 years ago

Codecov Report

Merging #335 (4d2a6cc) into main (4578481) will decrease coverage by 0.26%. The diff coverage is 72.97%.

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   61.48%   61.21%   -0.27%     
==========================================
  Files          30       30              
  Lines        2630     2617      -13     
  Branches      472      470       -2     
==========================================
- Hits         1617     1602      -15     
- Misses        888      891       +3     
+ Partials      125      124       -1     
Flag Coverage Δ
unittests 61.21% <72.97%> (-0.27%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stestr/commands/run.py 41.78% <0.00%> (-2.59%) :arrow_down:
stestr/subunit_runner/program.py 75.49% <76.92%> (-3.22%) :arrow_down:
stestr/selection.py 92.85% <90.00%> (-0.98%) :arrow_down:
stestr/commands/load.py 44.20% <100.00%> (-2.33%) :arrow_down:
stestr/subunit_trace.py 68.79% <100.00%> (+3.00%) :arrow_up:
stestr/test_processor.py 80.76% <100.00%> (ø)
stestr/testlist.py 80.00% <0.00%> (-10.00%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more