mtreinish / subunit-rust

A subunit v2 protocol implementation in Rust
Apache License 2.0
2 stars 2 forks source link

Stop buffering all of input stream on reads #5

Closed mtreinish closed 1 month ago

mtreinish commented 4 years ago

The subunit reader should not be reading the entire stream contents into buffer on reads. The stream can be quite large (with maybe multi-gigabyte attachments). Reading the entire contents obviously doesn't scale so we should avoid doing this and only read each packet one at a time as we process it.