search

mtrinder / Xamarin.Plugins

Cross platform xamarin and windows plugins for PCLs
MIT License
12 stars 5 forks source link

Build and revision numbers for UWP apps are swapped #4

Open maciek-codes opened 7 years ago

maciek-codes commented 7 years ago

The plugin swaps build and revision components of the version for UWP/WP apps.

The correct way of assembling a version string is shown in this MSDN article.

A fix is ready in the PR #3.

maciek-codes commented 7 years ago

@mtrinder thanks for completing the PR. Can you please push the new version to nuget.org feed?

mtrinder commented 7 years ago

Will do ASAP

Sent from my iPhone

On Mar 1, 2017, at 11:31 AM, Maciej Kumorek notifications@github.com<mailto:notifications@github.com> wrote:

@mtrinderhttps://github.com/mtrinder thanks for completing the PR. Can you please push the new version to nuget.orghttp://nuget.org feed?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mtrinder/Xamarin.Plugins/issues/4#issuecomment-283206144, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAe46gikPczi7KEHNdKW_uAH5gsKRwNOks5rhLwugaJpZM4LovP-.

winterdouglas commented 7 years ago

Hello guys. This fix has already been done? I installed the Nuget package and it still provides the wrong version on UWP.

Thanks.

mtrinder commented 7 years ago

Unfortunately no. I was on leave. Now started new job and have lost access to Windows 8 or 10 device. So I can't build some of the assemblies. Will try to spin up a virtual server in azure...

cbs-cbt commented 7 years ago

Hello, First of all, thank you for your plugin. To my opinion, it is more a problem of package settings in Visual studio. Microsoft choose to set "Build" instead of "Revision" in "package.appxmanifest. I don't know why. uwppackageversion Is it possible to base the version according to "Assembly Information" instead?