search

mtrojnar / osslsigncode

OpenSSL based Authenticode signing for PE/MSI/Java CAB files
Other
801 stars 131 forks source link

File handle of input file not closed #198

Closed egreathou closed 1 year ago

egreathou commented 1 year ago

I am compiling osslsigncode as a .lib instead of .exe for use within a .Net CLR C++ Dll. The input file to be signed is opened with the map_file function. CreateFile sets the local fhandle variable, but the handle is not closed until signcode_main exits. This appears to be by-design but would it be possible to also close the file handle after the input file is unmapped?

mtrojnar commented 1 year ago

A side question: Do you intend to distribute our .Net CLR C++ DLL? If so, how can I get a copy of your DLL's source code? Bear in mind the code is licensed on GPL 3.0 and your DLL is a derived work.

egreathou commented 1 year ago

Hi Michal,

We decided to take a different route and won't be using your code at this time. In our previous plans, we were not going to be redistributing it but rather, using it for a backend process on our servers. The servers would be used by our customers though, through interaction with our web UI. If you could help me determine if that usage is covered by the license then we will be sure to take that into consideration if our plans change in the future. Thank you for reaching out to me to let me know.

-Eric

On Wed, Jan 11, 2023, 5:32 AM Michał Trojnara @.***> wrote:

A side question: Do you intend to distribute our .Net CLR C++ DLL? If so, how can I get a copy of your DLL's source code? Bear in mind the code is licensed on GPL 3.0 and your DLL is a derived work.

— Reply to this email directly, view it on GitHub https://github.com/mtrojnar/osslsigncode/issues/198#issuecomment-1378613002, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATAJL3B5SYCQMZWOPH3ONATWR2K4BANCNFSM6AAAAAATDXQVRE . You are receiving this because you authored the thread.Message ID: @.***>

mtrojnar commented 1 year ago

@egreathou Thank you for the explanation. I case you change you mind, GPL indeed does not restrict the way you use the software, including customer-facing services.