mtrojnar / osslsigncode

OpenSSL based Authenticode signing for PE/MSI/Java CAB files
Other
729 stars 124 forks source link

Fixed uint32_t overflow when attaching a new MSI sector #399

Closed olszomal closed 1 month ago

mtrojnar commented 1 month ago

Shouldn't we also return 0 (failure) if OPENSSL_realloc returns NULL (memory allocation failure)?

I know we probably have more issues like that in our code. Maybe fixing it here is a good start.