search

mtrojnar / osslsigncode

OpenSSL based Authenticode signing for PE/MSI/Java CAB files
Other
806 stars 131 forks source link

Allow specifying blob contents when using -addUnauthenticatedBlob #402

Closed tyilo closed 2 months ago

tyilo commented 5 months ago

Instead of just adding the blob ---BEGIN_BLOB---...---END_BLOB--- which can then be replaced with another script, I think it would be more useful if we could specify the contents of the blob.

Something like

$ echo foo > blob.txt
$ osslsigncode add -addUnauthenticatedBlob blob.txt -in foo.exe -out foo-blob.exe
mtrojnar commented 5 months ago

Would you submit a PR?

tyilo commented 5 months ago

Would you submit a PR?

I'm going on vacation so it might be a while, but after that sure.

Do you think it is ok to make -addUnauthenticatedBlob require a path?

mtrojnar commented 5 months ago

Do you think it is ok to make -addUnauthenticatedBlob require a path?

Your PR should not break any existing scripts that invoke osslsigncode, so -addUnauthenticatedBlob should not require a path.

mtrojnar commented 2 months ago

Reimplemented in #404