search

mtrudel / bandit

Bandit is a pure Elixir HTTP server for Plug & WebSock applications
MIT License
1.7k stars 86 forks source link

accept hpax 1.0 #380

Closed rodrigues closed 4 months ago

rodrigues commented 4 months ago

Hi 👋

hpax 1.0.0 upgrade just removes a warning when compiling in Elixir 1.17:

warning: 62..@dynamic_table_start + length - 1 inside guards requires an explicit step, please write 62..@dynamic_table_start + length - 1//1 or 62..@dynamic_table_start + length - 1//-1 instead
  lib/hpax/table.ex:160: HPAX.Table.lookup_by_index/2

Thanks!

alisinabh commented 4 months ago

Since bandit already requires elixir 1.13+ and hpax 1.0.0 requires 1.12+ (lower) I guess we don't need to support 0.2.0 anymore?

cc @mtrudel

mtrudel commented 4 months ago

I think you're correct @alisinabh, but the only wrinkle is that mint only added version support for hpax 1.0.0 last week, so we'd be forcing people that use mint in their apps (which is a LOT of people) to update to at least mint 1.6.2 to solve their dev tree. Not ideal.

mtrudel commented 4 months ago

(Also ignore the busted CI; it's an issue with Req that I'm working up)

sleipnir commented 4 months ago

I think you're correct @alisinabh, but the only wrinkle is that mint only added version support for hpax 1.0.0 last week, so we'd be forcing people that use mint in their apps (which is a LOT of people) to update to at least mint 1.6.2 to solve their dev tree. Not ideal.

Hi @mtrudel I don't see any problem in updating because, in fact, the ideal is to stay updated, right?