mtrudel / hap

A HomeKit Accessory Protocol (HAP) Implementation for Elixir
MIT License
90 stars 9 forks source link

Failing to start HAP.HAPSessionTransport.sockname/1 with ThousandIsland 1.x #100

Closed hez closed 9 months ago

hez commented 9 months ago

There has been an update to ThousandIsland, I have 0.6.7 and the recent Phoenix update brought in 1.2.0 which causes the HAPSessionTransport to fail to start with:

** (Mix) Could not start application home_hub: HomeHub.Application.start(:normal, []) returned an error: shutdown: failed to start child: HomeHub.HAP.Supervisor
    ** (EXIT) shutdown: failed to start child: HAP
        ** (EXIT) shutdown: failed to start child: {Bandit, #Reference<0.1159261075.658505729.90071>}
            ** (EXIT) shutdown: failed to start child: :listener
                ** (EXIT) an exception was raised:
                    ** (UndefinedFunctionError) function HAP.HAPSessionTransport.sockname/1 is undefined or private
                        (hap 0.4.8) HAP.HAPSessionTransport.sockname(#Port<0.19>)
                        (thousand_island 1.2.0) lib/thousand_island/listener.ex:34: ThousandIsland.Listener.init/1
                        (stdlib 5.1.1) gen_server.erl:962: :gen_server.init_it/2
                        (stdlib 5.1.1) gen_server.erl:917: :gen_server.init_it/6
                        (stdlib 5.1.1) proc_lib.erl:241: :proc_lib.init_p_do_apply/3
hez commented 9 months ago

Looks solved by https://github.com/mtrudel/hap/pull/95

Maybe time to cut a new ver?

mtrudel commented 9 months ago

Yep. I was waiting for a couple of other things to land but I'll just get a new release out rather than waiting any longer.

Expect it later tonight.

hez commented 9 months ago

No rush on it, I was just doing ver bumping and hit this. No big features awaiting on it, if its worth waiting then lets! :D

mtrudel commented 9 months ago

0.4.9 published!

hez commented 9 months ago

Thank you! :D