Add air quality and water level sensor sensor

mtrudel / hap

A HomeKit Accessory Protocol (HAP) Implementation for Elixir

MIT License

91 stars 9 forks source link

Add air quality and water level sensor sensor #16

Closed philipgiuliani closed 3 years ago

philipgiuliani commented 3 years ago

I still have to add all the necessary characteristics for an AirQualitySensor-Service.

philipgiuliani commented 3 years ago

Merge request is ready!

mtrudel commented 3 years ago

Looks like you don't have owner updates enabled on your branch so I was unable to make the change - could you please change the two occurrences of VocDensity in code to VOCDensity? No need to change filenames; it's correct in both cases.

mtrudel commented 3 years ago

Good to go after that!

philipgiuliani commented 3 years ago

Done 👍

mtrudel commented 3 years ago

Merged; thanks for the PR!

mtrudel commented 3 years ago

Released as 0.4.5