Closed sholman closed 6 years ago
I think this is a great idea, I typically do this manually which should be updated. There are a few things that need to be discussed before any change is made:
The simple approach would be creating a manifest file for each module that is created in the solution. This could turn into quite a few manifest files. If you are building this many modules in one solution you may want to include them in one installer so it may be a good idea to give the user the option to have 1 or multiple manifest files.
Actually if you say yes it keeps the solution file and adds the project without losing the existing projects.
On Jul 28, 2018, at 10:24 AM, Andrew Hoefling notifications@github.com wrote:
I think this is a great idea, I typically do this manually which should be updated. There are a few things that need to be discussed before any change is made:
Manifest Files
The simple approach would be creating a manifest file for each module that is created in the solution. This could turn into quite a few manifest files. If you are building this many modules in one solution you may want to include them in one installer so it may be a good idea to give the user the option to have 1 or multiple manifest files.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
This is a limitation of yeoman. It will not allow a file to be altered without permission from the user. You could use —force to auto overwrite but I would not recommend that. Especially if you are upgrading your project from a previous generator version. Check out the faq section of the site. Mtrutledge.github.io/generator-dnn
On Jul 28, 2018, at 10:29 AM, Matt Rutledge mtrutledge@gmail.com wrote:
Actually if you say yes it keeps the solution file and adds the project without losing the existing projects.
On Jul 28, 2018, at 10:24 AM, Andrew Hoefling notifications@github.com wrote:
I think this is a great idea, I typically do this manually which should be updated. There are a few things that need to be discussed before any change is made:
Manifest Files
The simple approach would be creating a manifest file for each module that is created in the solution. This could turn into quite a few manifest files. If you are building this many modules in one solution you may want to include them in one installer so it may be a good idea to give the user the option to have 1 or multiple manifest files.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Describe the solution you'd like
It would be good to be able to run dnn-generator within an existing solution folder and it to default to (or ask) adding the new module project to the existing solution.
Additional context
Currently, it seems to notice the conflict adding the file and ask if you'd like to overwrite your .sln file. If you say No, it creates the module project, and you can add it to the solution manually.