search

mtrutledge / generator-dnn

Yeoman generator to scaffold DNN / DotNetNuke Modules and Themes.
MIT License
17 stars 10 forks source link

Gulp Scripts Included in Release Build #54

Closed SkyeHoefling closed 5 years ago

SkyeHoefling commented 5 years ago

Describe the bug

When you create the installer package the gulp scripts are included and are installed onto DNN. I believe this is in error since the scripts are just designed for building the module not running the module.

This was tested with just MVC but may be occurring in the other module patterns as well

To Reproduce

Steps to reproduce the behavior:

  1. Create a new DNN MVC module
  2. Package the module up for install
  3. Install the module into DNN

Expected Behavior

Actual Behavior

  1. Open up the folder DesktopModules/MVC/MyCompany/MyModule (where MyCompany and MyModule are the names you supplied to yo dnn.
  2. You will see the _BuildScripts folder with the gulp scripts

Screenshots

This is the directory output of an installed module using the DNN MVC template

image

david-poindexter commented 5 years ago

Good catch!

mtrutledge commented 5 years ago

I have this fixed in my development version I am working on now. I will add it to the 1.0.8 milestone.

Thanks Andrew!

On Aug 28, 2018, at 9:17 AM, Andrew Hoefling notifications@github.com wrote:

Describe the bug

When you create the installer package the gulp scripts are included and are installed onto DNN. I believe this is in error since the scripts are just designed for building the module not running the module.

This was tested with just MVC but may be occurring in the other module patterns as well

To Reproduce

Steps to reproduce the behavior:

Create a new DNN MVC module Package the module up for install Install the module into DNN Expected Behavior

The module installs without issue Build scripts are omitted from the release build Actual Behavior

Open up the folder DesktopModules/MVC/MyCompany/MyModule (where MyCompany and MyModule are the names you supplied to yo dnn. You will see the _BuildScripts folder with the gulp scripts Screenshots

This is the directory output of an installed module using the DNN MVC template

https://user-images.githubusercontent.com/17751436/44732630-b8bc0d80-aab3-11e8-92a9-f734751afbee.png — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mtrutledge/generator-dnn/issues/54, or mute the thread https://github.com/notifications/unsubscribe-auth/ACCJ_pKMHXEPSV59PgwTtxr-GAsDkVRgks5uVV8lgaJpZM4WP1aI.

mtrutledge commented 5 years ago

This is fixed in the development branch now and will be released with version 1.0.8

SkyeHoefling commented 5 years ago

@mtrutledge I noticed there are a lot of unnecessary artifacts being copied to release as well. For example one of my projects contains a README.txt file in a code folder. That folder structure is being copied over during release packaing. Should I open another issue about this so we can determine the best course of action on handling stuff like this

mtrutledge commented 5 years ago

That is expected behavior with a txt file. The packager does *\.txt. For this one instance I suppose it makes sense to only do the ReleaseNotes.txt and License.txt files. If you agree lets open a new issue.

On Aug 28, 2018, at 9:36 PM, Andrew Hoefling notifications@github.com wrote:

@mtrutledge https://github.com/mtrutledge I noticed there are a lot of unnecessary artifacts being copied to release as well. For example one of my projects contains a README.txt file in a code folder. That folder structure is being copied over during release packaing. Should I open another issue about this so we can determine the best course of action on handling stuff like this

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mtrutledge/generator-dnn/issues/54#issuecomment-416813261, or mute the thread https://github.com/notifications/unsubscribe-auth/ACCJ_o9DhTaF9KdMCnPhayK7EVVV8bbdks5uVgxVgaJpZM4WP1aI.