search

mtrutledge / generator-dnn

Yeoman generator to scaffold DNN / DotNetNuke Modules and Themes.
MIT License
17 stars 10 forks source link

remove the DnnAuthorize attribute on the Home Controller #57

Closed mtrutledge closed 5 years ago

mtrutledge commented 5 years ago

Related to Issue

Fixes #55

Description

remove the DnnAuthorize attribute on the Home Controller

mtrutledge commented 5 years ago

Done

valadas commented 5 years ago

If I am not mistaken the default is to block everything and you need to open it up to the permissions you need no? So I think for the public view it should be [AllowAnonymous]

mtrutledge commented 5 years ago

In other examples I have seen they don’t have a dnnauthorize at the top of the home controller for the mvc module. So I am not sure if it is required. I will test a few things before release.

On Aug 28, 2018, at 11:16 PM, Daniel Valadas notifications@github.com wrote:

If I am not mistaken the default is to block everything and you need to open it up to the permissions you need no? So I think for the public view it should be [AllowAnonymous]

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

valadas commented 5 years ago

I havent tested recently but I kind of remember that was one of the differences between normal MVC and the DnnController. By default it is all open and you need to close it to your needs but using Dnn it is all closed (hosts only) and you need to open to your needs. And is memory serves good, for a public controller it was the [AllowAnonymous] decoration. I may be confusing with webapi though, so yeah, give it a try before assuming I am right :)