Closed mariogarcc closed 5 years ago
I don't own a Windows machine, so I have no way to check for compatibility. I'll try to look into that in the near future.
Now it does build the wheel, but at least in my case, the CLI doesn't recognize "horrible-downlaoder" as a command (PowerShell just opens the file). I don't know much about this, but upon inspection, the script that appears in the Scripts folder in the Python 3 folder is just two files (horrible-downloader
and horrible-downloader.py
) that are not .exe
, compared to all the other scripts that appear there. I don't know if this is intended, as I said, but it's not working for me.
Also, those two files have something different between them on the line 75: the .py
file has shell=True
written, but the other one does not (again, don't know if intended or not).
Let me know if I can be of any assistance.
I cannot address the issue until Thursday. I'll open the issue again but won't do anything untill then.
Please delete the non .py
file and try running it again.
Note that I've added .py extension to my PATHEXT environment variable:
> set PathExt="%PathExt%;.PY"`
Just ran it using PowerShell and CMD, works both ways.
I uninstalled everything, reinstalled again following instructions at the frontpage and it doesn't work. The only thing I managed to achieve was this, where if I set PathExt without the "" it recognizes it afterwards but I do have to do that everytime I start the CMD.
What this does is open the horrible-downloader.py
file in Python3\Scripts\
(with my default code editor), and seems to do something afterwards as shown there in the commands.
C:\Users\Mario>set PathExt="%PathExt%;.PY"
C:\Users\Mario>horrible-downloader --help
'horrible-downloader' is not recognized as an internal or external command,
operable program or batch file.
C:\Users\Mario>set PathExt=%PathExt%;.PY
C:\Users\Mario>horrible-downloader --help
C:\Users\Mario>
[main 2019-08-08T23:14:18.805Z] update#setState idle
[main 2019-08-08T23:14:48.809Z] update#setState checking for updates
[main 2019-08-08T23:14:48.897Z] update#setState downloading
I'll try a different approach - compiling to exe. Hopefully this fixes the problem.
Please check out the newest version, it's currently under the windows branch
Seems to be working correctly! I did the following to install:
git clone https://github.com/jelomite/horrible-downloader.git
cd horrible-downloader
git checkout windows
pip install .
You may want to put that in some the readme or something if it is indeed the intended way to install it. I tried the example command horrible-downloader -d "one punch man" -e 1,2,4-6 -o ~/Videos/Anime
and it started downloading to the current user \Videos\Anime
folder (I didn't have that folder so it created it by itself). It seemed to be working but I stopped it because it was just for testing. I'll try and test this and other things like subscriptions tomorrow.
Thanks for your effort!
The new fix is now pushed into master, which means you can now install it as it's written in the readme.
About the output directory - remember that ~/Videos/Anime
is a Linux path. For Windows you should use something like C:\Users\<username>\...
.
You can also change this in the config file so you won't need to type it each time.
Sorry I cannot provide much more feedback - I have no idea what is happening here. I saw you were using Linux's command line, so I don't know if it doesn't work because I'm on Win10.