search

mtsmfm / language_server-ruby

A Ruby Language Server implementation
MIT License
259 stars 10 forks source link

Reconsider the repo name #18

Closed sandstrom closed 7 years ago

sandstrom commented 7 years ago

Great project! 😄

Would it make sense to rename this to language-server-ruby or even better language-server or language_server?

It feels more consistent to use one separator (-) instead of two, and afaik dash for repo-names is the most common one.

~I guess this question goes for the sibling project too (language_server-protocol-ruby).~

adaedra commented 7 years ago

Just passing through, this name is consistent with gem naming conventions : http://guides.rubygems.org/name-your-gem/.

sandstrom commented 7 years ago

Thanks, I didn't know! That clears some things up. 😄

I still think it would be neat with another repo name, ideally just language_server.

mtsmfm commented 7 years ago

@sandstrom

Thank you for your opinion! As @adaedra remarked, I use _ as a word separator and - as a namespace separator. I want to use LanguageServer as a top level module so I named this gem as language_server.

I still think it would be neat with another repo name, ideally just language_server.

Perhaps I create another language server for another language so I want to include "ruby" in this repo name. And language_server and language_server-protocol are Ruby gems. Obviously, it's for Ruby so I don't want to include "ruby" for gem name.

I'll close this issue for now but feel free to add comments or re-open this issue! Anyway, I'm glad to hear your opinion!