search

mtth / tracing

Distributed tracing
https://hackage.haskell.org/package/tracing
BSD 3-Clause "New" or "Revised" License
24 stars 11 forks source link

Add Content-Type header when sending JSON to /api/v2/spans #1

Closed timhabermaas closed 3 years ago

timhabermaas commented 4 years ago

Without the Content-Type Jaeger (tested using version 1.18) responded with "Unsupported Content-Type":

> curl -XPOST -d @foo2.json http://localhost:9411/api/v2/spans
Unsupported Content-Type
timhabermaas commented 4 years ago

This fix should be verifiable by using Jaeger's all-in-one Docker image (https://www.jaegertracing.io/docs/1.18/getting-started/#all-in-one) and pointing Zipkins settingsHostname to localhost and settingsPort to 9411.

With the Content-Type set all seems to be working fine when sending data to Jaeger. Including tags and annotations (called events in Jaeger):

Screen Shot 2020-06-15 at 22 28 48
mtth commented 3 years ago

Thanks for the PR @timhabermaas and apologies for the slow reply. I wasn't getting notifications from this repo and am just going through the PRs now. I think this was fixed by https://github.com/mtth/tracing/pull/3.