search

mtth / tracing

Distributed tracing
https://hackage.haskell.org/package/tracing
BSD 3-Clause "New" or "Revised" License
24 stars 11 forks source link

Support base16-bytestring-1.0.0.0 #5

Closed akshaymankar closed 3 years ago

akshaymankar commented 4 years ago

Fixes #4

mtth commented 3 years ago

Thanks for the PR @akshaymankar. I've just fixed the issue in https://github.com/mtth/tracing/commit/47a15f08c0d4b82cfb665cdbda4866e1341eea0f; it seemed preferable to avoid using packages that aren't in Stackage's LTS.

alaendle commented 3 years ago

@mtth - since base16-bytestring >= 1.0.0.0 is now available (and required) by stackage nightly maybe this change can be applied (and the package reenabled on stackage)?

mtth commented 3 years ago

@alaendle - SGTM, I'll try to update it this weekend.

FTR: https://github.com/commercialhaskell/stackage/issues/5649

alaendle commented 3 years ago

@mtth But also enjoy the Easter holidays! 🐇

mtth commented 3 years ago

0.0.6.2 now available on Hackage uses the updated base16-bytestring.

alaendle commented 3 years ago

Time to re-enable it on stackage master and maybe also lts18 (https://github.com/commercialhaskell/stackage/blob/a4e9060dfd73253517af54ee3eb14ac7421ca0cc/build-constraints.yaml#L156)? I would have created a corresponding PR myself, but as far as I understand this something that should be reserved for package maintainers.