search

mttkay / replicant

A REPL for the Android Debug Bridge (ADB)
MIT License
123 stars 9 forks source link

Pass CTRL + C to the currently running adb command, if any #26

Open veeti opened 10 years ago

veeti commented 10 years ago

Allows exiting logcat and repeating loop situations (multiple devices connected and no device selected) without killing Replicant itself.

GitHub: fixes #24

mttkay commented 10 years ago

Sorry missed this. Will review over the weekend. Meanwhile, it looks like the build is failing?

mttkay commented 10 years ago

I got around to testing this, but it's not working well for me. In fact, I get the reverse effect now: while CTRL+C-ing out of an ADB command seems to work, when doing the same with built in interactive commands like !logcat, it immediately exits replicant.

This needs more work before I can merge it back.

mttkay commented 10 years ago

As to your question about !logcat: it adds logic on top of adb logcat such as filtering by process ID of the active package by default. There's an open issue to evolve it further, like colorizing log output, see #3

I'd be open for suggestions though if such things can be achieved in a simpler way, i.e. by not creating a custom command.