nesquena
commented
11 years ago :+1: Hey Matt,
Project looks good overall, nice work. A few points of feedback:
- Proper layout naming, uses relative layouts, string resources, etc
- Properly reused the same method
queryGoogleAndDisplayfor both initial load and the pagination - "Load More" button on the view and hooked up paginating (although it clears the previous results when I load more, such that I lose older results)
- Properly used spinners to allow users to select values
- Properly send and receive relevant filters using a bundle to pass data between activities
- One thing to consider is rather than sending and returning all the filter values separately as keys, might have introduced a serializable model (i.e
SearchFilters.java) representing all the filters which was passed back and forth in the activities in the bundle
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be very important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
Google Image Search is finished.
I stuck to the project guidelines this project and didn't have a chance yet to implement the infinite scroll or load more images by scrolling...busy week.
One discrepancy between this app and the screenshots is my app only shows 8 images at a time due to a Google Image cap. I didn't invest the additional time to get one more image, add it to the GridView, refresh and have a completely filled 3x3 grid.
/cc @nesquena @timothy1ee