search

mttlee0 / android-twitter-redux

v2.0 of a simple Twitter Client
0 stars 0 forks source link

Twitter Redux v1.0 finished #1

Open mttlee0 opened 11 years ago

mttlee0 commented 11 years ago

Twitter Redux is finished.

Still no infinite scroll or load more tweets button, but all other requirements are satisfied.

Added feature to click on any profile image on the home timeline and pull up the profile details for that user. For persisted data I used SharedPreferences instead of SQLLite for offline support.

/cc @nesquena @timothy1ee

nesquena commented 11 years ago

:+1: Hey Matt, project looks good. A few points of feedback:

Nice work overall, hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, .

Wednesday we are covered the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Sept 30th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group apps that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.

mttlee0 commented 11 years ago

Thanks for the quick feedback Nathan, it is very helpful.

On Fri, Sep 20, 2013 at 2:19 PM, Nathan Esquenazi notifications@github.comwrote:

[image: :+1:] Hey Matt, project looks good. A few points of feedback:

  • Used FrameLayout to act as a container for timeline tab content
  • Setup ActionBar Tabs mode with the Home and Mentions timeline tabs
    • Should checkout tabs cliffnoteshttps://github.com/thecodepath/android_guides/wiki/Creating-and-Using-Fragments#fragments-and-tabsto see how you might do this in a Gingerbread compatible way and using a "FragmentTabListener" which is recommended approach by Google.
    • Setup the base fragment class that the timelines all extend from
    • Setup home timeline fragment without much unnecessary code duplication
    • Setup mentions timeline fragment without much unnecessary code duplication
    • Setup persistence with shared preferences on failure
    • OPTIONAL: Should consider implementing endless paginationhttps://github.com/thecodepath/android_guides/wiki/Endless-Scrolling-with-AdapterViewsas a further learning opportunity
    • Properly setup user profile view with profile header and a user timeline fragment
    • Can view my profile by clicking on the ActionBar
    • Clicking on a users profile image takes me to their profile
    • Use of imageView tag to manage the user brought up
    • ANSWER: You asked about efficiency of using tag. First storing the User object itself in the tag is probably overkill, should probably store just the user's screen_name. You could also just set the variable to "final" and avoid using tag altogether.
    • Compose works and refreshes the home timeline properly
    • OPTIONAL: Probably not necessary to totally replace the fragment manually in the onActivityResult. Better just to select the tabhttp://developer.android.com/reference/android/app/ActionBar.html#setSelectedNavigationItem(int)and let that take care of it.
    • OPTIONAL: Right now if I click on a friend's profile and then click on their image again in their profile, it opens up a second profile. This sort of profile recursion is kind of odd from the UI perspective, real twitter client disallows stacking up navigation to the same user's profile over and over
    • OPTIONAL: Should play with ActiveAndroid in the future to get a feel for DB persistence

Nice work overall, hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, .

Wednesday we are covered the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Sept 30th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group apps that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.

— Reply to this email directly or view it on GitHubhttps://github.com/mttlee0/android-twitter-redux/issues/1#issuecomment-24842008 .