search

mtxr / SublimeText-SQLTools

SQLTools for Sublime Text 3
https://code.mteixeira.dev/SublimeText-SQLTools/
GNU General Public License v3.0
177 stars 40 forks source link

Show execution status on the status bar #130

Closed ngr-t closed 7 years ago

ngr-t commented 7 years ago

Issue Type

Description

I think it's helpful to show if a query is under execution in the status bar. Maybe we don't have that kind of thing now. I imagine of one with text animation like Package Control has, but just texts like "busy" or something should be OK.

I'll make a PR for this if you think it a good feature.

Versions

Coteh commented 7 years ago

I was looking into this sort of feature not too long ago actually, and as I was taking a look at the codebase, I noticed that there already is a status message implemented. However, it never seemed to show up for me. Then I found out that what seems to be happening is that the status message clear call on this line is clearing out the status message before it appears on the screen. This can be observed by commenting out said line, saving, then reexecuting query once plugin reloads. I am not sure what the best solution to this problem is at this time, but I just thought that I at least bring this to your attention before you work on this feature. Perhaps the Command thread is running the createOutput callback before it actually finishes the query? That's my best guess at the moment as to what's happening and where to look at for solving this problem.

An animation for the status bar like the one in Package Control would be really cool and I would find it very helpful to have an indicator of progress that stands out on the UI when running a query.

ngr-t commented 7 years ago

Thank you for advice! I'll look into a good fix for this.

tkopets commented 7 years ago

It used to work a while ago, but with the addition of recent functionality, it is now broken. I will fix it so it works as it used to work before. Feel free to improve it.

ngr-t commented 7 years ago

Thank you for fixing! I think of adding animation, but not very soon (so sorry but I'm little busy now). Therefore I close this issue for now.