search

mtxr / SublimeText-SQLTools

SQLTools for Sublime Text 3
https://code.mteixeira.dev/SublimeText-SQLTools/
GNU General Public License v3.0
177 stars 40 forks source link

Default key binding for st_select_connection doesn't work in MacOS #83

Closed tompollard closed 7 years ago

tompollard commented 7 years ago

Love this package...thanks for sharing it. Minor issue, but for me the default key binding for changing the database connection doesn't work in MacOS (hitting the keys has no visible effect).

I'm running Sublime 3 (Build 3126) on MacOS (Version 10.12.5 Beta). I have tested the same bindings on a linux system and they work as expected.

The default key binding for changing the database connection is:

{ "keys": ["ctrl+alt+e"], "command": "st_select_connection" }

For now, I'm just overriding this with the following user setting:

{ "keys": ["ctrl+e", "ctrl+c"], "command": "st_select_connection" }
tkopets commented 7 years ago

Thanks for your feedback! New default key combination is:

{ "keys": ["ctrl+super+e"], "command": "st_select_connection" }

which would be: Ctrl+Cmd+e

Fix will be available in next release.

tompollard commented 7 years ago

Great, thanks again.

mtxr commented 7 years ago

Thanks Taras! Are you able to create tags?

On Fri, Apr 21, 2017 at 2:08 PM, Tom Pollard notifications@github.com wrote:

Great, thanks again.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mtxr/SQLTools/issues/83#issuecomment-296248666, or mute the thread https://github.com/notifications/unsubscribe-auth/AArL6a2TWcsckB4vV4hIBLJ4zTALSfR_ks5ryOJ2gaJpZM4NC_e0 .

tkopets commented 7 years ago

@mtxr Sure, I can. I will create one.

I have a question regarding new tags/releases of SQLTools: Is there anything you have to update codewise (except documentation) each time you do a new tag/release?

E.g. Do I need to update version in SQLTools.py to match latest tag ? Right now we have:

__version__ = "v0.6.7"

Or anything else that comes to your mind related to releases/tags?

Also what tool you have used to create animated gifs as seen in the readme?

mtxr commented 7 years ago

Sure, needs update there.

The tool I used was a python script I found once (used on ubuntu, now I switched to a new OS), it doesn't come to my mind now. But you can use any tool you want, no restrictions.

I will create a Contribute.md file to help people develop and make a pull request soon, than we can put some info there

On Fri, Apr 21, 2017 at 4:54 PM, Taras Kopets notifications@github.com wrote:

@mtxr https://github.com/mtxr Sure, I can. I will create one.

I have a question regarding new tags/releases of SQLTools: Is there anything you have to update codewise (except documentation) each time you do a new tag/release?

E.g. Do I need to update version in SQLTools.py https://github.com/mtxr/SQLTools/blob/6cfd03fa6ec56b6314cb4a9af3b9ff17942d523b/SQLTools.py#L1 to match latest tag ? Right now we have:

version = "v0.6.7"

Or anything else that comes to your mind related to releases/tags?

Also what tool you have used to create animated gifs as seen in the readme?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mtxr/SQLTools/issues/83#issuecomment-296291226, or mute the thread https://github.com/notifications/unsubscribe-auth/AArL6VjJMyOol2wvRioQKNL1_R50tIBZks5ryQmAgaJpZM4NC_e0 .

tkopets commented 7 years ago

Thanks! It would be great to have Contribution notice!