search

mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.44k stars 291 forks source link

After registering duplicate connection name, Connections tree is empty #1085

Closed dyegoaurelio closed 1 year ago

dyegoaurelio commented 1 year ago

Describe the bug The new option to save passwords on vscode's keystore is registering the connection using only it's name as a unique identifier.

So by creating two connections that uses the SQLTools Driver Credentials, and have the exact same name, database and driver, the extension won't work until one connection is manually erased from the config file

image

I think the extension should either prevent duplicate connection names, or add a unique identifier to the connection ID.

gjsjohnmurray commented 1 year ago

This problem existed before 0.27.0 and is unrelated to the new capability for drivers to store passwords in the keystore. See https://github.com/mtxr/vscode-sqltools/issues/668#issuecomment-991088634