mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.44k stars 291 forks source link

Connections using `connectString` store redundant `port` property #1087

Closed gjsjohnmurray closed 1 year ago

gjsjohnmurray commented 1 year ago

Describe the bug After defining a connection that uses a connection string (connectString property) the JSON includes a redundant port property.

To Reproduce Steps to reproduce the behavior:

  1. Start defining a new connection that uses the MSSQL, MySQL or PostgreSQL driver.
  2. Set connection method to "Connection String".
  3. Save the definition and observe that the JSON includes a redundant port property with a default value.

Expected behavior No port property in the JSON of a connection definition that has a connectString property.

Desktop (please complete the following information):