mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.49k stars 299 forks source link

sql code is highlighted #1105

Closed generateui closed 1 year ago

generateui commented 1 year ago

Describe the bug sql code that is visible in vscode is all highlighted

To Reproduce Steps to reproduce the behavior:

  1. Go to a sql file
  2. open it
  3. observe all text in the file is selected

Expected behavior text is only highlighted when it is selected

Screenshots https://imgur.com/a/MGxUsYs

Desktop (please complete the following information):

Additional context the plugin is now unworkable, as highlighted text completely breaks my normal coding workflow.

as this is related to the setting sqltools.highlightQuery, the default of this setting is true which imho should be false - to stay true to the vscode default behavior.

gjsjohnmurray commented 1 year ago

If you change that setting do you get the behaviour that you want?

generateui commented 1 year ago

Yes, I guess the default setting is not alike the way vscode handles all the other syntax highlighting behaviors, so it was surprising to me. Selecting text without any user intervention is not that default behvior implemented by vscode (and any other plugin) as far as I have seen. Therefore, I'd argue to change that default setting to not surprise the user.

gjsjohnmurray commented 1 year ago

Changing a default usually ends up upsetting at least one existing user who thinks something got broken, so I don't think we're likely to do this.