search

mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.49k stars 299 forks source link

TiDB Driver Support #1112

Closed Icemap closed 1 year ago

Icemap commented 1 year ago

Is your feature request related to a problem? Please describe.

AFAIK, the SQLTools didn't support TiDB. TiDB (/’taɪdiːbi:/, "Ti" stands for Titanium) is an open-source distributed SQL database that supports Hybrid Transactional and Analytical Processing (HTAP) workloads.

Describe the solution you'd like Support it.

gjsjohnmurray commented 1 year ago

Community-written driver extensions are welcome. See https://vscode-sqltools.mteixeira.dev/en/contributing/support-new-drivers/

Icemap commented 1 year ago

Hi, @gjsjohnmurray. Thanks for your reply! Can I write the support code in the MySQL driver? Just like the CRDB in the PG driver. TiDB is compatible with MySQL protocol.

gjsjohnmurray commented 1 year ago

@mtxr I have requested a review from you, particularly because @Icemap has added TiDB support into the existing MySQL driver rather than contributing a standalone driver.

Seems to me that a benefit of that approach is MySQL / MariaDB users might gain new stuff (SSL support improvements?), but the switch from the mysql package to the mysql2 one brings risks for existing users.

Icemap commented 1 year ago

@gjsjohnmurray If the mysql2 will bring some risks, and it's unacceptable, I can turn it back to the mysql lib. But IMO, mysql lib wasn't updated for a long while(~3 years). Maybe we can move to the mysql2. Please give me your advice! THX!

FYI: NPM pages:

Icemap commented 1 year ago

Hi @gjsjohnmurray, @mtxr. Anything new?

dveeden commented 1 year ago

Shouldn't this be closed now #1113 has been merged? Or are there more changes needed?

gjsjohnmurray commented 1 year ago

Closing this now the driver has been published.