Implement drag and drop objects

mtxr / vscode-sqltools

Database management for VSCode

https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link

MIT License

1.49k stars 299 forks source link

Implement drag and drop objects #1141

Closed ScriptPup closed 1 year ago

ScriptPup commented 1 year ago

PR implementing requested object-name drag and drop functionality requested in #1135 & #10.

Dragging resource groups does nothing (as they are just logical containers and mean nothing to the underlying SQL engine).

efe6d2a6-70cf-4976-a5aa-3e38d924b328

Thank you for your contribution! Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You have made the needed changes to the docs (N/A)
[x] You have written a description of what is the purpose of this pull request above

ScriptPup commented 1 year ago

I meant to mention in the PR, but forgot - The new feature will not work until version 1.78 is released (or using the insider's build).

That being said, I did test on 1.77 and there are no breaking changing due to this feature. The functionality will simply be latent until VSCode's underlying bugs are fixed in 1.78.

ScriptPup commented 1 year ago

Confirmed today that this enhancement works with the updated production 1.78 release of VSCode.

emil14 commented 1 year ago

Can we merge this one?

bombillazo commented 1 year ago

Hello @mtxr , can this be reviewed and merged if ok?