mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.44k stars 291 forks source link

Does not work in LAN with no internet connection.(This is with openvscode server) #1149

Closed woshilaiba closed 1 year ago

woshilaiba commented 1 year ago

Describe the bug

I have a server in LAN, and it can not access the internet , when i add new connection from the plugin panel, it failed with a message "cannot resolve 19mq80582sdfgdfgsdagasfda.vscode-cdn.net's server IP address coule not be found".

Does it being used only when the there's a internet connection? Thank you

To Reproduce Steps to reproduce the behavior:

  1. on a pc with no internet connection
  2. open the sqltools panel
  3. add new connection
  4. got the error page "cannot resolve 19mq80582sdfgdfgsdagasfda.vscode-cdn.net's server IP address coule not be found".

Expected behavior I hope it works in LAN with no internet connection.

Desktop (please complete the following information):

gjsjohnmurray commented 1 year ago

Does this also happen if you set "telemetry.telemetryLevel": "off" in your VS Code settings?

woshilaiba commented 1 year ago

Does this also happen if you set "telemetry.telemetryLevel": "off" in your VS Code settings?

yeah, on window10, I try it when i disconnect the internet at home pc, it works. tomorrow i'll try it on my office pc which has no internet. Thank YOU!

woshilaiba commented 1 year ago

Test on my office PC without internet connection, and set "telemetry.telemetryLevel": "off": OS: windows 7 VS Code Version: 1.76.2 Driver: MySQL/MariaDB Result: PASS

VS Code Version: OpenVSCode Server 1.77.3 running on Centos7.6 OS: linux APP: Chrome_x64 109.0.5414 running on Windows7 Driver: MySQL/MariaDB Result: FAILED when failed,like this image

+++++++++++++++++++++++++++++++++++++ Test on my home PC with internet connection: OS: windows 10 VS Code Version: 1.77.3 Driver: MySQL/MariaDB Result: PASS

VS Code Version: OpenVSCode Server 1.77.3 running on Debian 11 OS: linux APP: Yandex Browser_x64 23.3.3.719 running on Windows10 Driver: MySQL/MariaDB Result: PASS

when success,like this 20230512155114

image

+++++++++++++++++++++++++++++++++++++++++

seems none of telemetry‘s bussiness (maybe the webview?) any idea?

woshilaiba commented 1 year ago

VS Code Version: OpenVSCode Server 1.77.3 running on Debian 11

the openvscode server is from https://github.com/gitpod-io/openvscode-server/releases

gjsjohnmurray commented 1 year ago

Maybe https://github.com/gitpod-io/openvscode-server/discussions/383 is relevant?

woshilaiba commented 1 year ago

Maybe gitpod-io/openvscode-server#383 is relevant?

Thank you!