[connection].session.sql file opens very eagerly

mtxr / vscode-sqltools

Database management for VSCode

https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link

MIT License

1.44k stars 291 forks source link

[connection].session.sql file opens very eagerly #1169

Closed archiewood closed 1 year ago

archiewood commented 1 year ago

Not sure this is a bug as such - more a UX thing

I normally have SQL files open already that I want to run when I start using SQLtools.

Then I want to check for a table name or something so I open the sidebar explorer and the [connection].session.sql file opens over the top of them.

Repro

set up a connection
open the sidebar
click on the connection to explore the db

Snowflake driver

Expected

No [connection].session.sql file opens

Actual

[connection].session.sql file opens and I have to close it before running my SQL

CleanShot 2023-06-21 at 18 53 31

Proposals

Setting to configure this file opening or not
?Turn this off by default

gjsjohnmurray commented 1 year ago

Does https://github.com/mtxr/vscode-sqltools/pull/1161 (just merged and not yet published) help you?

archiewood commented 1 year ago

I don't think so, I still want to be able to see the query for any queries I run, I just don't want to be presented with a blank file when I connect to the db

gjsjohnmurray commented 1 year ago

Please try with "sqltools.autoOpenSessionFiles": false

archiewood commented 1 year ago

Ah that's the setting I need, thanks.

I'd propose that this be set to false by default, but if other people find it helpful I understand!

Happy to close this issue now or leave it open if you want to get feedback on this.

gjsjohnmurray commented 1 year ago

Changing defaults can be unpopular, so I'm going to close this. Doing that won't prevent further feedback though.