mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.44k stars 291 forks source link

Node runtime detection fails when `oh-my-zsh` update is available #1187

Open robertrossmann opened 11 months ago

robertrossmann commented 11 months ago

Describe the bug Node runtime detection seems to spawn an interactive shell, and if that shell asks a question the detection may fail.

To Reproduce Steps to reproduce the behavior:

  1. Start VS Code with sqltools installed
  2. Have the shell ask you a question (for me, it's the oh-my-zsh update confirmation)
  3. Notice that the first character of the node version detection is consumed by the question and the command that is actually executed is therefore incorrect (see screenshot)
  4. Node version detection fails

Expected behavior The node detection is executed from a non-interactive shell so that other programs running in it know not to ask questions.

Screenshots

Screenshot 2023-07-17 at 9 46 17

Desktop (please complete the following information):

Additional context

None.