mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.43k stars 291 forks source link

What's your policy on adding links to premium extensions integrated with SQL Tools and drivers? #1200

Closed RandomFractals closed 8 months ago

RandomFractals commented 11 months ago

We'd like to add our DuckDB Pro Tools, PRQL Pro Tools, and our new Markdown SQL Pro Tools extensions info to your public Community Drivers documentation page at: https://vscode-sqltools.mteixeira.dev/en/drivers

You can find more info in the new Show & Tell discussion we started to share some features info: https://github.com/mtxr/vscode-sqltools/discussions/1199

duckdb-tools-extensions

prql-code-lens

markdown-sql-pro-tools

gjsjohnmurray commented 11 months ago

I wonder if having a new page called, say, "Related Tools" would make more sense. Or else rename the "Drivers" page to "Drivers and Related Tools".

@mtxr what do you think?

RandomFractals commented 11 months ago

I wonder if having a new page called, say, "Related Tools" would make more sense. Or else rename the "Drivers" page to "Drivers and Related Tools".

@mtxr what do you think?

Maybe new Plugins section or Premium extensions, as some of those extensions like PRQL Pro Tools and new Markdown SQL Pro Tools are not database drivers. They just use SQL Tools connections and query results display features, but are actually registered as SQL Tools plugins in extension activation event to log extra PRQL to SQL info, etc.

RandomFractals commented 10 months ago

How about we add DuckDB Pro Tools to the current Drivers section in your docs, and will add new Related Tools section on that page with links to the new PRQL Code Lens and Markdown SQL Pro Tools?

Will submit a PR today.

RandomFractals commented 10 months ago

@gjsjohnmurray let me know if this entry would be appropriate to add DuckDB Pro Tools to your drivers list:

duckdb-pro-tools-links

Note that because DuckDB Pro Tools is a premium vscode extension that requires github sponsorship to access, I added Sign Up link and link to new DuckDB Pro Tools docs repo.

There are no other premium SQL Tools drivers and vscode extensions that we know of, so this entry is a bit different from the others. Hopefully, more folks will add other premium SQL tools later on.

mtxr commented 10 months ago

I think we should differentiate it somehow @gjsjohnmurray. I've been looking into other project to see how they handle this, and there's not "standard practice" for that. We can just choose, but I don't have a strong opinion about how to go about that yet.

To be safe, I'ld keep as is cause users would have the drivers all grouped to choose which to install and what are the advantages of each of them, so the way it is now a days, I think it's fine.

If we see this list growing, we can then think again how to organize these "premium extensions".

@gjsjohnmurray let me know what you think

gjsjohnmurray commented 10 months ago

@mtxr for now I'm happy with this approach, which is why I approved the PR and merged it. As you say, if we get a lot more of them maybe we should review.

RandomFractals commented 10 months ago

Great! Thanks for merging that addition.

Should we create new Related Tools section as @gjsjohnmurray suggested to add the other two extensions using SQL Tools as a dependency?

I can submit that PR tomorrow for us to close this ticket.

mtxr commented 10 months ago

Which other extensions are you referring to?

Are they paid like yours?

Cause many extensions use sqltools as a base extension, so just to see if I understood what you meant.

On Fri, 18 Aug 2023 at 18:29 Taras Novak @.***> wrote:

Great! Thanks for merging that addition.

Should we created new Related Tools section as @gjsjohnmurray https://github.com/gjsjohnmurray suggested to add the other two extensions using SQL Tools as a dependency?

I can submit that PR tomorrow for us to close this ticket.

— Reply to this email directly, view it on GitHub https://github.com/mtxr/vscode-sqltools/issues/1200#issuecomment-1684453808, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMX2I6ECTVAO7MHSGUNS3XV7ND3ANCNFSM6AAAAAA3EGOKIM . You are receiving this because you were mentioned.Message ID: @.***>

-- Matheus https://mteixeira.dev

RandomFractals commented 10 months ago

The other two SQL Tools plugins I mentioned in this ticket originally are PRQL Code Lens and Markdown SQL Pro Tools. Thy are not database drivers, but they are registered as SQL Tools plugins on activation, list SQL Tools as extension dependency, and use active SQL Tools database connection and execute SQL command to run SQL queries for PRQL docs converted to SQL and SQL code blocks and magics extracted from various markdown documents.

I'll submit that PR and let you and @gjsjohnmurray decide if you'd like to merge new Related Tools section and have them listed in your docs. I think more such generic SQL Tools extensions could be created for various documents with SQL statements, where they are specific to various markdown and code docs, and users can choose to install and use them, if interested.

RandomFractals commented 8 months ago

Resolved by #1204