mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.43k stars 291 forks source link

`//`(Floor Division) on CockroachDB query formatting fixed #1235

Closed jonasbadstuebner closed 8 months ago

jonasbadstuebner commented 8 months ago

The floor division opeator // is special to CockroachDB I think. I found it in other DBMS' Documentation but only for comments (and none of them are officiall supported by sqltools), so keeping these two slashes without whitespace inbetween no matter what should always at least be "more valid" than splitting them apart. Therefore I do not expect unwanted side effects because of this change.

fixes #1234

Thank you for your contribution! Before submitting this PR, please make sure:

gjsjohnmurray commented 7 months ago

We just published 0.28.1 with this change included. Thanks again!