search

mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.43k stars 290 forks source link

[Fix][#72][#799][#1264]Not able to connect to AWS RDS postgresql #1265

Closed jqknono closed 6 months ago

jqknono commented 6 months ago

Fix not able to connect to AWS RDS Postgresql

gjsjohnmurray commented 6 months ago

Is this changing the default behaviour of the driver, making it less secure?

My understanding of https://nodejs.org/api/tls.html#tlscreateserveroptions-secureconnectionlistener is that we should only pass "rejectUnauthorized": false if the user explicitly opts for this.

Isn't it sufficient to add "default": true to the definition of rejectUnauthorized in connection.schema.json?

gjsjohnmurray commented 6 months ago

Thanks for making the changes. I noticed you have left the property required. Is this necessary?

jqknono commented 6 months ago

Is this changing the default behaviour of the driver, making it less secure?

My understanding of https://nodejs.org/api/tls.html#tlscreateserveroptions-secureconnectionlistener is that we should only pass "rejectUnauthorized": false if the user explicitly opts for this.

Isn't it sufficient to add "default": true to the definition of rejectUnauthorized in connection.schema.json?

Yes, you're right. I revert the changing of rejectUnauthorized, it's now default "true". Tested both Windows/Linux. image

jqknono commented 6 months ago

Thanks for making the changes. I noticed you have left the property required. Is this necessary?

required is not necessary, I just removed it.