search

mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.5k stars 302 forks source link

Fix destructure property 'name' of 'undefined' error (#723) #950

Closed gjsjohnmurray closed 2 years ago

gjsjohnmurray commented 2 years ago

MySQL driver would report Cannot destructure property 'name' of 'undefined' as it is undefined (see #723) if query did not return columns (e.g. a DROP or an INSERT)

codecov[bot] commented 2 years ago

Codecov Report

Merging #950 (d53967d) into dev (4a7a601) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #950      +/-   ##
==========================================
- Coverage   10.11%   10.10%   -0.01%     
==========================================
  Files         173      173              
  Lines        5795     5797       +2     
  Branches     1354     1355       +1     
==========================================
  Hits          586      586              
- Misses       5209     5211       +2
Flag Coverage Δ
extension 10.10% <0.00%> (-0.01%) :arrow_down:
formatter 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/driver.mysql/src/ls/default.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.