search

mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.48k stars 297 forks source link

Sqlite3 v5 #953

Closed gjsjohnmurray closed 2 years ago

gjsjohnmurray commented 2 years ago

Use sqlite@5.0.11 instead of @4.2.0

codecov[bot] commented 2 years ago

Codecov Report

Merging #953 (d2eb00c) into dev (e5f12db) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #953   +/-   ##
=======================================
  Coverage   10.06%   10.06%           
=======================================
  Files         173      173           
  Lines        5834     5834           
  Branches     1366     1366           
=======================================
  Hits          587      587           
  Misses       5247     5247
Flag Coverage Δ
extension 10.06% <0.00%> (ø)
formatter 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/driver.sqlite/src/ls/driver.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gjsjohnmurray commented 2 years ago

@mtxr the aim of this PR is to resolve #858 and maybe #921.

I had also hoped to remove the need for install-time dependency resolution and building (see commit history of the PR), but failed at this so reverted that experiment's three commits.

The branch passed basic testing I performed using the /test/project.code-workspace

gjsjohnmurray commented 2 years ago

Zip of a manual build of the driver VSIX from this PR.

sqltools-driver-sqlite-0.3.1-dev.953.zip