mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.48k stars 297 forks source link

avoid infinity loop if auto install fails for drivers #955

Closed mtxr closed 2 years ago

mtxr commented 2 years ago

Describe here what is this PR about and what we are achieving merging this.

I realized that when installing some drivers if the npm install fails, the terminal auto closes making it harder for the users to provide feedback. Also that was cause the install flow to stay in a loop.

This PR address this issue.


Thank you for your contribution! Before submitting this PR, please make sure:

codecov[bot] commented 2 years ago

Codecov Report

Merging #955 (dd92ea8) into dev (a049e68) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #955   +/-   ##
=======================================
  Coverage   10.06%   10.06%           
=======================================
  Files         173      173           
  Lines        5834     5832    -2     
  Branches     1366     1366           
=======================================
  Hits          587      587           
+ Misses       5247     5245    -2     
Flag Coverage Δ
extension 10.06% <0.00%> (+<0.01%) :arrow_up:
formatter 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...connection-manager/dependency-manager/extension.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gjsjohnmurray commented 2 years ago

I suppose this may help us diagnose #921 if the answers to my latest questions there don't lead to a breakthrough.