mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.48k stars 297 forks source link

Make automatic Node detection work on Windows, and only do it if required #960

Closed gjsjohnmurray closed 2 years ago

gjsjohnmurray commented 2 years ago

Fixes #959 and make the detection process work correctly on Windows too.


Thank you for your contribution! Before submitting this PR, please make sure:

codecov[bot] commented 2 years ago

Codecov Report

Merging #960 (1f4811f) into dev (37c6ad0) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #960      +/-   ##
==========================================
- Coverage   10.00%   10.00%   -0.01%     
==========================================
  Files         175      175              
  Lines        5867     5869       +2     
  Branches     1376     1377       +1     
==========================================
  Hits          587      587              
- Misses       5280     5282       +2     
Flag Coverage Δ
extension 10.00% <0.00%> (-0.01%) :arrow_down:
formatter 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/extension/src/language-client/client.ts 0.00% <0.00%> (ø)
.../extension/src/language-client/detect-node-path.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.