mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.48k stars 297 forks source link

Install dependencies and report errors during connection test (#903) #963

Closed gjsjohnmurray closed 2 years ago

gjsjohnmurray commented 2 years ago

This PR fixes the problems reported in #903.


Thank you for your contribution! Before submitting this PR, please make sure:

codecov[bot] commented 2 years ago

Codecov Report

Merging #963 (aa108f6) into dev (37c6ad0) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #963      +/-   ##
==========================================
- Coverage   10.00%   10.00%   -0.01%     
==========================================
  Files         175      175              
  Lines        5867     5870       +3     
  Branches     1376     1377       +1     
==========================================
  Hits          587      587              
- Misses       5280     5283       +3     
Flag Coverage Δ
extension 10.00% <0.00%> (-0.01%) :arrow_down:
formatter 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/driver.sqlite/src/extension.ts 0.00% <0.00%> (ø)
...ages/plugins/connection-manager/language-server.ts 0.00% <0.00%> (ø)
...ges/plugins/connection-manager/webview/settings.ts 0.00% <0.00%> (ø)
...ttings/components/SettingsFormStepWidget/index.tsx 0.00% <0.00%> (ø)
...ger/webview/ui/screens/Settings/context/reducer.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mtxr commented 2 years ago

@gjsjohnmurray everything lgtm, but before merging, check my previous message, I believe we can just get rid of that weird piece of code. let me know your thoughts