mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.48k stars 297 forks source link

Fix theming of Save Connection button (fixes #798) #965

Closed gjsjohnmurray closed 2 years ago

gjsjohnmurray commented 2 years ago

This PR fixes #798

With Monokai theme now: image


Thank you for your contribution! Before submitting this PR, please make sure:

codecov[bot] commented 2 years ago

Codecov Report

Merging #965 (1701682) into dev (37c6ad0) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #965   +/-   ##
=======================================
  Coverage   10.00%   10.00%           
=======================================
  Files         175      175           
  Lines        5867     5867           
  Branches     1376     1376           
=======================================
  Hits          587      587           
  Misses       5280     5280           
Flag Coverage Δ
extension 10.00% <0.00%> (ø)
formatter 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ttings/components/SettingsFormStepWidget/index.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mtxr commented 2 years ago

LGTM. I've tested with some themes, both dark and light. all looking good.