search

mtxr / vscode-sqltools

Database management for VSCode
https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link
MIT License
1.48k stars 297 forks source link

Fix some flakiness caused by PR #957 #967

Closed gjsjohnmurray closed 2 years ago

gjsjohnmurray commented 2 years ago

On Windows at least, the node path auto-detect changes from #957 were producing intermittent failures. One of these was caused by vscode.env.shell sometimes being empty, perhaps a consequence of being called very early in VS Code startup.

gjsjohnmurray commented 2 years ago

Upstream issue https://github.com/microsoft/vscode/issues/160694