fix: fixes slow formatting of queries with large no. of lines - Githubissues

mtxr / vscode-sqltools

Database management for VSCode

https://vscode-sqltools.mteixeira.dev?utm_source=github&utm_medium=homepage-link

MIT License

1.5k stars 302 forks source link

fix: fixes slow formatting of queries with large no. of lines #978

Closed sivaramasubramanian closed 2 years ago

sivaramasubramanian commented 2 years ago

Related to #977

This change removes RegEx-based trimming to improve performance. There may be other places where performance could be improved. After this change, the query mentioned in #977 gets formatted in under 1s.

Describe here what is this PR about and what we are achieving merging this.

Thank you for your contribution! Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You have made the needed changes to the docs
[x] You have written a description of what is the purpose of this pull request above

gjsjohnmurray commented 2 years ago

@mtxr do you see any downside to this change?