mtyeh411 / mediawiki-bootstrap

A customizable responsive Bootstrap MediaWiki skin.
GNU General Public License v2.0
78 stars 19 forks source link

Header popup menus always visible #17

Closed pdusen closed 11 years ago

pdusen commented 11 years ago

This is on the newest Google Chrome running Ubuntu 12.10. Just did a fresh install of this skin on my wiki (git clone --recursive etc etc). However, the popup menus are is always visible and clicking on their associated arrows has no effect.

responsive-error

pdusen commented 11 years ago

From Special:Version:

Product Version MediaWiki 1.20.2 PHP 5.3.10-1ubuntu3.5 (cgi-fcgi) MySQL 5.5.29-0ubuntu0.12.04.1

mtyeh411 commented 11 years ago

Okay, I'm having difficulty replicating this issue. I've tested in MediaWiki versions 1.18.5, 1.19.2 (REL1_19), 1.20alpha (REL1_20), 1.20.2, and 1.21alpha on PHP 5.3.3/MySQL 5.0.95. I'll see if I can replicate on PHP 5.3.10, but I'm not sure if that is the issue.

I'm on latest Chrome version (Version 24.0.1312.57).

Does Chrome Developer Tools console show any error messages?

Also, let's see which Bootstrap commit you are pointing to. If you change to the boostrap/ directory and run git log -1 what is the last commit SHA (you can just give first 5 characters)?

PS, while troubleshooting, I came across another issue. It may be related, but you can try pulling down the latest commit and seeing if it solves your problem.

pdusen commented 11 years ago

D'oh... I pulled your latest commit before running git log -1. If it helps, it showed me this while pulling the commit:

   e1e3e2b..8776c89  master     -> origin/master

The changes you made didn't fix the problem.

As far as developer tools, I'm not seeing any console output while loading the page or clicking anything on it.

I made a slight error in my original post; the version of chrome I'm testing with is Version 25.0.1364.84 beta. However, on another machine running Windows 7 with Chrome Version 24.0.1312.57 I am seeing the exact same issue.

mtyeh411 commented 11 years ago

I'm trying to determine the Bootstrap commit you checked out just to be sure that this isn't due to anything changed from the Bootstrap js scripts. Run git log -1 after you cd bootstrap. It should begin with b261f97, right?

pdusen commented 11 years ago

I'm currently getting this

commit 8776c89920de8459d3fb27c63707bcd619ff2e48
Author: dev.mtyeh411 <dev.mtyeh411@gmail.com>
Date:   Wed Feb 20 10:31:05 2013 -0500

    assign explode result to variable
mtyeh411 commented 11 years ago

Sorry for confusion. Run git log -1 within the bootstrap directory within mediawiki-bootstrap (ie, first change into the directory with cd skins/mediawiki-bootstrap/bootstrap from $IP install path -- assuming you have typical MediaWiki file structure).

I'm noticing that your setup is similar to that in issue #8 ... I wonder if this is related.

I'm still trying to recreate your issue. I have PHP 5.3.10 running on my dev box, but am getting fatal errors from the MediaWiki includes/db/DatabaseMysql.php file. It looks like I'll just spin up a fresh vm that match your specs.

Since we're not seeing any error messages from Chrome, what about your server logs (I'm specifically looking for PHP or MySQL errors)? Anything PHP or SQL errors thrown if you set MediaWiki debug settings?

pdusen commented 11 years ago

Alright, from the bootstrap dir:

commit b261f9781bbf31f499cb55c49451dc0c0ad43062
Merge: ffb4d90 99c3b78
Author: Jacob Thornton <jacobthornton@gmail.com>
Date:   Wed Apr 25 22:19:49 2012 -0700

    Merge pull request #3226 from aziz/patch-6

    No need to specify units when a value is 0, thanks to RECESS

I haven't been able to find any errors through logs or debug settings. It is most puzzling.

pdusen commented 11 years ago

I have just tested with the latest Firefox (19) with the exact same results. Now it's REALLY puzzling.

mtyeh411 commented 11 years ago

So I'm still having issues replicating your issues. I've spun up an Ubuntu 12.10 machine, downgraded to PHP 5.3.10 and am running MySQL 5.5. I am not seeing this at all in either Chrome or Firefox.

[EDIT: screenshot shows MediaWiki 1.21alpha, but I also switched to MediaWiki 1.20.2 on same server and still did not see.]

Here is screenshot: Screen shot 2013-02-20 at 4 09 46 PM

I don't know how much more I can help since there's nothing for me to go off of. Sorry...

My only other guess is that you have another extension or some common site-wide js (like in MediaWiki:Common.js) that is colliding with this event. Perhaps see if disabling EVERYTHING except the skin still shows the buggy behavior. If not, then try adding your extensions in one at a time, and maybe we can isolate what is giving you a problem.

I'll leave this issue open. If you figure out what is going on, please comment and close the issue (if it's resolved). I'll close out if there is no response after some time. Thanks.

pdusen commented 11 years ago

Disabling my extensions did nothing and my MediaWiki:Common.js is empty.

I've noticed that for some reason, upon loading the site, there is a display:inline property applied to the dropdown-menus:

Capture

And after disabling it:

Capture1

Any thoughts?

pdusen commented 11 years ago

I found this in my MediaWiki:Common.css

.navbar ul {
    display: inline;
    white-space: nowrap;
}

I blindly copied the whole thing from Wikipedia several weeks ago in order to correctly format several templates I copied from there.

I've commented it out for now, but I don't know if this is causing me any formatting issues elsewhere yet. Can you think of an alternate solution?

Mithgol commented 11 years ago

Well, you could leave .navbar ul { display: inline; } intact but add some .navbar ul.dropdown-menu { . . . } rule to override it for the dropdowns. What do you think?

pdusen commented 11 years ago

I'll mess with it. In any event, clearly this wasn't an issue with your skin. Thanks for your help nonetheless.