search

mtytel / helm

Helm - a free polyphonic synth with lots of modulation
http://tytel.org/helm
GNU General Public License v3.0
2.37k stars 203 forks source link

Impossible to only install LV2 or standalone #137

Closed simonvanderveldt closed 7 years ago

simonvanderveldt commented 7 years ago

First of all thanks for the awesome synth! Really like it, both the sounds it can generate as well as the well thought through and good looking UI!

We're working at packaging Helm for gentoo (see https://github.com/gentoo-audio/audio-overlay/issues/16) and I ran into the following. One of the important things we strive to do for gentoo is give the user choice what to build and install. Currently one can choose which targets to make: standalone, lv2 and vst, but make install always triggers all, which includes both lv2 and standalone.

Now, there's already a install_vst target, I can create a PR to add install_lv2 and install_standalone. Would you be OK with this? And do you have any feedback or suggestions how you'd like it to work before I create a PR?

mtytel commented 7 years ago

How's this? https://github.com/mtytel/helm/commit/23af45f4fce36d4921e1d4ff8388c60956c51684

simonvanderveldt commented 7 years ago

How's this?

@mtytel Well, that's awesome! ;) And a lot quicker than me whipping up a PR :P Thanks!

Since the first target (all) now builds everything install should probably also install everything?

And the readme should probably be updated to match these changes?

mtytel commented 7 years ago

Good catch. I was keeping install_vst out of it for a license reason but it looks like I can build with the GPL version of the VST SDK so I've included it now. I've also included the VST SDK in the source (since it's GPL now) so you don't have to download it separately anymore.

Updated README too.

simonvanderveldt commented 7 years ago

@mtytel Looks good, thanks for the quick fixes! I'll run some builds this weekend, if I run into anything strange I'll let you know. Looking at the code/changes it should work fine though :)