search

mtytel / helm

Helm - a free polyphonic synth with lots of modulation
http://tytel.org/helm
GNU General Public License v3.0
2.36k stars 200 forks source link

Aftertouch not mapped continuously #181

Open kjyv opened 6 years ago

kjyv commented 6 years ago

When mapping aftertouch to a parameter, I see that it is changed at the same time the note on is sent (i.e. I play the note). While still holding the key down, the parameter is not changing anymore even though I can see that channel pressure events are sent continuously using a midi monitor.

jfrey-xx commented 6 years ago

Hello,

I think I had a similar issue, could it be related to #170?

mtytel commented 6 years ago

I think channel pressure is different than aftertouch. I'll see if I can default to channel pressure if aftertouch isn't available.

jfrey-xx commented 6 years ago

I think implemented that in my PR #170, @kjyv you can maybe test the code and see if the new behavior matches what you expect?

kjyv commented 6 years ago

Ah this sounds likely. Both types of aftertouch should be handled then. @jfrey-xx I've tried your PR and it works as intended, see my PR comment for a suggestion to fix a runtime error.