search

mtytel / helm

Helm - a free polyphonic synth with lots of modulation
http://tytel.org/helm
GNU General Public License v3.0
2.36k stars 200 forks source link

Arpeggiator doesn't scale with sample rate in Ardour5 #209

Closed aeonik closed 1 year ago

aeonik commented 5 years ago

Hello, The arpeggiator does not scale properly with different sample rates. The faster the sample rate, the faster Arp notes play.

This can be replicated on my system by:

  1. Creating two test projects in Ardour5 1a. Project 1 sample rate is set to 44.1 KHz 1.b Project 2 sample rate is set to 48 KHz
  2. Create the same MIDI track with 4 whole notes.
  3. I configure Helm Arp to 1/4 quarter note frequency. 4a. Project 1 plays an expected 4 notes. 4b. Project 2 plays 5 notes, off time.

This bug scales with sample rate: the faster the sample rate, the more erroneous notes play. This affects both my Arch and Ubuntu systems. Helm v 0.9.0, Ardour v 5.12.0

Regards, Aeonik

gonX commented 5 years ago

Might be the same as #182?

community/helm 0.9.0-7 on Arch has that issue, but git does not.

aeonik commented 5 years ago

Sebastian, It looks like the same issue. Great find!

I can build the Git version on my Arch system tonight to confirm this hypothesis.

On Wed, Sep 19, 2018, 04:39 Sebastian Jensen notifications@github.com wrote:

Might be the same as #182 https://github.com/mtytel/helm/issues/182?

community/helm 0.9.0-7 on Arch has that issue, but git does not.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mtytel/helm/issues/209#issuecomment-422711093, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVpsKFavUVyxqzBBZup2w6cy2ir77psks5ucgK2gaJpZM4WvRTU .

mtytel commented 5 years ago

Yeah I haven't released a new build in a while.. I've been busy working on Helm's successor!

Bleuzen commented 5 years ago

@mtytel Will you keep Helm maintained?

aeonik commented 5 years ago

Matt, Thanks for sharing the news! I can't wait to see what you have in store. Let us know when it becomes available.

-Aeonik

On Sun, Oct 7, 2018 at 9:29 AM Elias notifications@github.com wrote:

@mtytel https://github.com/mtytel Will you keep Helm maintained?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mtytel/helm/issues/209#issuecomment-427653683, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVpsE7EzUCvQT0CEXPf2ZYb7eOWo-aWks5uigGwgaJpZM4WvRTU .

unfa commented 5 years ago

I think I just hit this bug. I'm always running at 48 kHz - and Arpeggiator is too fast for my session's tempo, even though it correctly got 140 BPM.

rburgosnavas commented 5 years ago

Just noticed this error too. The arp is slightly faster than the track's tempo on Renoise (Linux)

jpriebe commented 5 years ago

I saw the problem on Ableton Live / Windows 10. Using a sample rate of 44100, the arpeggiator was synced with tempo. When I changed it to 48000, the arp was out of sync. Helm's LFOs, stutter, and sequencer were fine, however.

xard-dev commented 3 years ago

As I experimented with updating JUCE to 5.4.7 I noticed that this bug seems to be gone from the build using the newer JUCE when tested on 48 kHz project in Ardour. Now the arpeggio is in sync as expected.

xard-dev commented 3 years ago

The patch is in form of pull request now.