search

mtytel / helm

Helm - a free polyphonic synth with lots of modulation
http://tytel.org/helm
GNU General Public License v3.0
2.35k stars 201 forks source link

gcc 9.1 compatibility fixes #233

Open Jikstra opened 4 years ago

Jikstra commented 4 years ago

This pr backports https://github.com/WeAreROLI/JUCE/commit/4e0adb2af8b424c43d22bd431011c9a6c57d36b6 to make helm compile with gcc 9.1 again. Fixes https://github.com/mtytel/helm/issues/232

Jacalz commented 4 years ago

@mtytel Could you please merge this and make sure to tag a new release? The current release is totally broken on GCC 9.1 and later :(

Jikstra commented 4 years ago

@Jacalz as I don't have any merge rights on this repo I can't do a single thing. @mtytel has to help us with this.

Jacalz commented 4 years ago

@Jacalz as I don't have any merge rights on this repo I can't do a single thing. @mtytel has to help us with this.

Yes I am well aware of that. That’s why I tagged @mtytel in the comment to indicate that it was aimed at him. On a further note, I have tested this and everything seems to work as expected 👍

Jikstra commented 4 years ago

Oh sorry, I somehow got confused...

simonvanderveldt commented 4 years ago

@mtytel Any chance this could be merged? Don't want to include patches in the package for it if it's not necessary.

dvzrv commented 4 years ago

@mtytel Is there something keeping this patch from being merged?

Currently the package on Arch Linux is failing reproducible builds because of this.

Skrylar commented 4 years ago

Thank you for fixing this :+1: