mtytel / helm

Helm - a free polyphonic synth with lots of modulation
http://tytel.org/helm
GNU General Public License v3.0
2.35k stars 201 forks source link

Some Factory Presets contents dont match their names #239

Open rbnpi opened 4 years ago

rbnpi commented 4 years ago

I have just been writing a TouchOSC front end to use in conjunction with Sonic Pi to select Helm Patches. I noticed that three of the SFX factory presets contents do not match up with their names. SF whistle1 has contents for Brass Soft Stutter SF Whistle2 has contents for Whistle_1 SF Whistle3 has contents for Whistle_2

There doesn't actually appear to be a whistle_3 eg here is the beginning content of Whistle 1.helm

{
   "license": "Patch (c) by SF.  This patch is licensed under a Creative Commons Attribution 4.0 International License.  You should have received a copy of the license along with this work.  If not, see <http://creativecommons.org/licenses/by/4.0/>.",
  "synth_version": "0.8.6",
  "patch_name": "Brass_Soft_Stutter",
  "folder_name": "Keys",
  "author": "SF",

and for Whistle 2.helm

{
  "license": "Patch (c) by SF.  This patch is licensed under a Creative Commons Attribution 4.0 International License.  You should have received a copy of the license along with this work.  If not, see <http://creativecommons.org/licenses/by/4.0/>.",
  "synth_version": "0.8.6",
  "patch_name": "Whistle_1",
  "folder_name": "SFX",
  "author": "SF",

I wondered why my selector which uses midi cc signals to select patches wasn't working properly until I looked at these contents! IT works fine for everything else. I was using the names index of the patches in the folder to generate the midi cc data to send. EDIT looks like selecting patches via midi control uses the internal name of the patch to display ,whereas selcting from the in built browser uses the filename? The patches sound the same whichever way you select.